Update Inductor windows tutorial with xpu support #3309
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3309
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @svekars , could you help review it? |
|
Hi @svekars @AlannaBurke , Could you please review this update at your earliest convenience? We need to add this updated link to pytorch/pytorch#150397 before the release of v2.7. Thank you! |
|
|
||
| Download and install `MSVC <https://visualstudio.microsoft.com/downloads/>`_. | ||
|
|
||
| During Installation, select ``Workloads`` table then ``Desktop & Mobile`` Section, check mark on ``Desktop Development with C++`` and then install. |
There was a problem hiding this comment.
Might be nice to have screenshots here.
There was a problem hiding this comment.
I've added a screenshot here
| Windows CPU inductor also support C++ compiler `LLVM Compiler <https://github.com/llvm/llvm-project/releases>`_ and `Intel Compiler <https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler-download.html>`_ for better performance. | ||
| Please check `Alternative Compiler for better performance on CPU <#alternative-compiler-for-better-performance>`_. | ||
|
|
||
| Conda Installation |
There was a problem hiding this comment.
Per pytorch/pytorch#149551, Conda is no longer being used.
There was a problem hiding this comment.
Remove the conda installation and let user create and activate virtual environment on their own
| Install a Compiler | ||
| ^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| C++ compiler is required for torchinductor optimization, let's take Microsoft Visual C++ (MSVC) as an example. |
There was a problem hiding this comment.
keep formatting consistent, ie, TorchInductor
There was a problem hiding this comment.
keep formatting for all the TorchInductor
|
Hi @svekars @AlannaBurke , all the comments have been addressed, please help review again! |
|
Hi @HamidShojanazeri, |
|
Hi @svekars , any updates? |
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
|
Hi @svekars, all the suggestions have been committed. Please help approve! Thank you! |
Description
Update Inductor windows tutorial with xpu support
cc @gujinghui @EikanWang @fengyuan14 @guangyey